Hi everyone.

Really frustrated. Sometimes when I test my map, my code works fine. Other times, even if I don't change the code at all, it doesn't. It always seems to revolve around my use of GetWorldPosition (and sometimes GetCharacterUnit). But I can't figure out any pattern to it. Here's my ScriptPostLoad: And the relevant section of my error log:

Is that even a function? It's not listed in the LUA callback reference

http://secretsociety.com/forum/download ... erence.txt

Yep. I know it's not on the list but it does work (usually). It outputs a character or entity's location in xyz form. Others on GT use it as well.

Edit: Could this be caused by the fact that I define xplayer, yplayer, and zplayer, as well as xenemy, yenemy, and zenemy, as 0 right away? Should I leave them undefined until I need them?

bad argument #1 to `GetWorldPosition' (string expected, got nil)

The error says there's a problem with the first argument being passed to GetWorldPosition(). It requires the argument to be a string, but it's getting a nil instead. So then look to see what you're passing in: the result of a GetCharacterUnit() call. So if GetCharacterUnit() is returning nil, then it means the character doesn't have a unit, meaning that player hasn't spawned yet or is dead.

[RDH]Zerted wrote:... meaning that player hasn't spawned yet or is dead.

That makes complete sense now that I think of it. The pattern/problem is, I think, that this error gets returned whenever I kill a guard. So when the function EnemyDistance enters the for loop to check how close the guards are, it eventually finds one guard that is dead and returns this error which mucks up the whole game. So what's my best option here, to include something like this? In my post-work brain right now I'm thinking that would effectively deal with a nil value by telling the for loop to just move right past the dead unit by breaking, and try the next one. Am I wrong? Is there a better way of doing it?

(Thank you soooo much for your help on this so far.)

Edit: It doesn't seem to work...

jedimoose32 wrote: In my post-work brain right now I'm thinking that would effectively deal with a nil value by telling the for loop to just move right past the dead unit by breaking, and try the next one. Am I wrong? Is there a better way of doing it?

(Thank you soooo much for your help on this so far.)

Edit: It doesn't seem to work...

Now I have very little experience with BF2's lua, but generally speaking in every language I know of, using break in a for loop breaks the loop entirely, not just that iteration of the loop. So if it hits a dead unit that isn't the last guard its checking then the loop is getting terminated early.

You're right, I realized that as I was going to bed last night. So I've got to find another way around this. Some way to tell the for loop to move on past the GetWorldPosition if the GetCharacterUnit returns a nil value. I'm sure this would be no problem for someone with more coding experience.

Edit: So what I've done (credit to LRKfm for the idea) is register all of my team 2 units in a table like this: And then unregister them whenever they die: So now the distance check uses "for unitnum = 0, (table.getn(enemiesAlive) - 1) do", which should mean, for example, if there are 8 enemies alive then spots 0 through 7 on Team 2 should be filled, right? Meaning there should be 8 keys in enemiesAlive. So I tell the for loop to start at 0 and work its way up to 8 - 1 (7). This makes sense to me and I honestly thought it would work but I'm still getting the same error! (Here's the actual code for the EnemyDistance function: Got it! (edit: Turns out I didn't, see below)

Pairs, man. Pairs are a lifesaver. So I changed the way my tables work a bit, and then instead of having the EnemyDistance function check every unit by getting GetTeamMember(2,x), I just kept a list of which enemies are alive, and then had the GetWorldPosition check each living member of that team. Here's the finished code!

In most programming languages "continue" skips to the next iteration of a loop. However for some reason Lua doesn't have "continue". So the standard practice is to use an if statement instead. Quick Example:or

Interesting. Are you saying I could implement something similar to have the code skip members of team 2 that are dead? Because I tried something similar and still had the GetWorldPosition trying to read the unit's nil value. Maybe I was going about it the wrong way though.

Edit: To be more specific I had something along the lines of: (Sorry for the poor formatting, I'm on my phone at work)

Edit 2: I shouldn't have marked the thread [Solved]... I did some more testing and now I'm getting an instant CTD sometimes when the script is checking the enemy distance. Here's the last thing it shows me in the error log each time (not always #6): I'm not sure if it was something I changed. It's worth mentioning that a friend recommended I try Eclipse LDT for lua editing, so I made a tiny little change to a completely unrelated part of the script in that environment and saved, and only notice the problem afterward. This could be a false correlation though.

At the very least GetCharacterUnit(i) should be GetCharacterUnit(GetTeamMember(2,i)).

Your OnCharacterDeath performs a GetCharacterUnit() on a character it knows is dead. Dead characters don't have units. Don't do that. It looks like you're always and only removing nil from ListEnemiesAlive.

Okay that makes sense. Even so, the crash appears to be coming from the game trying to read my table in function EnemyDistance... You can see it starts the function just fine and prints "this is enemy # ..." but then dies. If I'm only removing nils from my table with OnCharacterDeath then what is the GetWorldPosition finding in there that breaks the game?