-= Gametoast.com =-

Maveritchell wrote:A couple quick observations:

1) Your "command description" is a nonsensical string - it's looking for a localization string, just like the example given in the comment.

Maveritchell wrote:2) Where are the variables all_inf_etc. defined? It looks like you could have mistakenly placed those as variables instead of strings, but they'd return nil that way as well.

Maveritchell wrote:And further, I'm not 100% sure whether you can properly read in from a side .lvl file after the script is loaded. It'd be better if you read in the optional units in ScriptInit and then made your custom command simply call for them.

commanderawesome wrote:

Maveritchell wrote:2) Where are the variables all_inf_etc. defined? It looks like you could have mistakenly placed those as variables instead of strings, but they'd return nil that way as well.

I'm trying to get it to check if each class exists. It still crashed even before I added those.

all_inf_etc

all_inf_rifleman = true 

...

if all_inf_rifleman == true then
SetClassProperty(...)
end

commanderawesome wrote:I'm trying to get it to check if each class exists. It still crashed even before I added those.

if soldier[1] == "all_inf_rifleman" then
SetClassProperty("all_inf_rifleman", "GeometryName", "all_inf_snowtrooper")
end

Maveritchell wrote:Edit: Nedarb, you're making the same mistake. "All_inf_rifleman" as a reference is a string, not a variable.).

Nedarb7 wrote:

Maveritchell wrote:Edit: Nedarb, you're making the same mistake. "All_inf_rifleman" as a reference is a string, not a variable.).

With the code he had, I was just explaining what would need to be fixed.

Maveritchell wrote:if everything in the code you showed us worked (or had already stopped working before you added it), why are you showing us this?

Maveritchell wrote:You're trying to check to see (assuming you're working with SetupTeams) what class is assigned to the soldier table, and to do that you'd want to do something like:

Code: Select all

if soldier[1] == "all_inf_rifleman" then
SetClassProperty("all_inf_rifleman", "GeometryName", "all_inf_snowtrooper")
end

I don't know offhand if that's local to the SetupTeams .lua, but you should be able to check and verify that.

[RDH]Zerted wrote:
You can use uf_isKnownClass(<class string>) to check if a unit class has been added to a side or not. uf_isKnownClass() returns false if the class hasn't been added to a side and a number if it has.

Example:

Code: Select all

if uf_isKnownClass('all_inf_rifleman') ~= false then
    SetClassProperty("all_inf_rifleman", "GeometryName", "all_inf_snowtrooper")
end

Rewriting all those if statements into a loop would be even better:

Hidden/Spoiler:

[code]--class properties to reconfigure
--format: <unit class> = { {<first property to change>}, {<second property to change>}, {etc...} ,}
---- format of <# property to change>
---- * table of 3 elements
---- ** 1st element: class name
---- ** 2nd element: property name
---- ** 3rd element: new property value
local changes = {
all_inf_rifleman = {{"all_inf_rifleman", "GeometryName", "all_inf_snowtrooper"},},
all_inf_rocketeer = {{"all_inf_rocketeer", "OverrideTexture", "all_inf_vanguard_hoth"}, {"all_inf_rocketeer", "OverrideTexture2", "Rebel_face02"},},
}

--apply all the property changes
for key, value in pairs(changes) do
if uf_isKnownClass(key) ~= false then
for _,arguments in ipairs(value) do
SetClassProperty(arguments[1], arguments[2], arguments[3])
end
end
end[/code]

[RDH]Zerted wrote: *It's better to localize your strings, but when the localization key doesn't exist the game simple outputs the key it was looking for. Thus using text in any key location does work, but you won't be able to translate it (which doesn't matter for personal projects).

Maveritchell wrote:That shouldn't cause a crash, though - a variable that's not set just returns nil, which he's already checking against. Consequently, none of his classes are changing, because none of the "if" statements are met.

commanderawesome wrote:Mav's solution didn't work. I will try Zerted's next.